Skip to content

add support to override the container name#964

Draft
ksdpmx wants to merge 1 commit intoapache:masterfrom
ksdpmx:feature/update-container-name
Draft

add support to override the container name#964
ksdpmx wants to merge 1 commit intoapache:masterfrom
ksdpmx:feature/update-container-name

Conversation

@ksdpmx
Copy link
Copy Markdown

@ksdpmx ksdpmx commented Apr 18, 2026

Summary

Use apisix.name for the APISIX container name in deployment.yaml.

Why

The container name was using .Chart.Name directly, while other chart-generated names already rely on the shared apisix.name helper. This caused inconsistent naming behavior when chart naming is customized.

Using the shared helper keeps the Deployment aligned with the rest of the chart and ensures the container name follows the same naming path as other generated resources, especially when nameOverride is used.

This is also useful when the APISIX chart is consumed as a dependency from another chart and chart naming is customized through overrides or aliases, e.g. apisixControlPlane, apisixDataPlane. However, the rendered container name still needs to remain a valid lowercase RFC 1123 label.

Impact

  • fixes naming inconsistency in rendered manifests
  • keeps default behavior unchanged for default installs
  • aligns container naming with the chart's shared naming helper

@ksdpmx ksdpmx marked this pull request as draft April 18, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant